Re: [Xen-devel] [PATCH v4 07/17] x86/VPMU: Add public xenpmu.h

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.01.14 at 17:49, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> wrote:
> On 01/24/2014 09:54 AM, Jan Beulich wrote:
>>>>> On 21.01.14 at 20:08, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> wrote:
>>> Add xenpmu.h header file,
>> To me, naming a public Xen header (other than the core one) xen*.h
>> is redundant. There's no information lost if you just called it pmu.h.
> 
> I was trying to keep filename and top-level data structures the same 
> (although now that I changed xenpmu_ prefix to xen_pmu_ they no longer 
> are).
> 
>>
>> Also I think you ought to use plural here.
> 
> I'd prefer to keep the arch-independent and -dependent file names the same.

Right, that's appreciated. Nevertheless it's two of them, i.e.
"Add pmu.h header files, ..."

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel