Re: [Xen-devel] [PATCH v5] coverity: Store the modelling file in the source tree.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-01-24 at 18:04 +0100, Tim Deegan wrote:
> At 16:59 +0000 on 24 Jan (1390579158), George Dunlap wrote:
> > On 01/24/2014 04:57 PM, Andrew Cooper wrote:
> > > On 24/01/14 16:52, George Dunlap wrote:
> > >> The name of the file might be a bit confusing though, if people think
> > >> it is supposed to be compliled... would it make sense maybe to call it
> > >> ".txt", and include some instructions at the top with a line that says
> > >> "---- cut here 8< ---" or something?
> > >>
> > >>   -George
> > > Not really - Coverity uses the file extension to work out how to
> > > interpret the modelling file.  ".c" is correct here, and will cause
> > > smart text editors to apply proper syntax highlighting.
> > >
> > > Alternates are .cpp and .java, depending on the primary language of the
> > > project.
> > 
> > Yes, I assumed that *coverity* needs it to be a .c.  But it doesn't need 
> > to be a .c file in the xen tree -- the instructions could say, "Place 
> > the text below into a file named coverity_model.c".
> 
> +1.  I don't think it's confusing for humans but we don't want
> e.g. ctags/cscope or IDEs picking up the coverity versions
> of things.

Do you run tags on the whole of xen.git? I run it individually on the
xen and tools subdirs, because all the other cruft in the tree is just
too noisy otherwise.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel