Re: [Xen-devel] [PATCH] minios: Correct HYPERVISOR_physdev_op()

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-01-24 at 18:28 +0000, Andrew Cooper wrote:
> A physdev_op is a two argument hypercall, taking a command paramter and an
> optional pointer to a structure.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> CC: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

This hypercall is unused in minios and stubdoms I think? (Trying to
gauge how critical the error is).

> ---
>  extras/mini-os/include/x86/x86_32/hypercall-x86_32.h |    4 ++--
>  extras/mini-os/include/x86/x86_64/hypercall-x86_64.h |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/extras/mini-os/include/x86/x86_32/hypercall-x86_32.h 
> b/extras/mini-os/include/x86/x86_32/hypercall-x86_32.h
> index ef52ecd..dcfbe41 100644
> --- a/extras/mini-os/include/x86/x86_32/hypercall-x86_32.h
> +++ b/extras/mini-os/include/x86/x86_32/hypercall-x86_32.h
> @@ -255,9 +255,9 @@ HYPERVISOR_console_io(
>  
>  static inline int
>  HYPERVISOR_physdev_op(
> -     void *physdev_op)
> +     int cmd, void *physdev_op)
>  {
> -     return _hypercall1(int, physdev_op, physdev_op);
> +     return _hypercall2(int, physdev_op, cmd, physdev_op);
>  }
>  
>  static inline int
> diff --git a/extras/mini-os/include/x86/x86_64/hypercall-x86_64.h 
> b/extras/mini-os/include/x86/x86_64/hypercall-x86_64.h
> index 513d74e..7083763 100644
> --- a/extras/mini-os/include/x86/x86_64/hypercall-x86_64.h
> +++ b/extras/mini-os/include/x86/x86_64/hypercall-x86_64.h
> @@ -256,9 +256,9 @@ HYPERVISOR_console_io(
>  
>  static inline int
>  HYPERVISOR_physdev_op(
> -     void *physdev_op)
> +     int cmd, void *physdev_op)
>  {
> -     return _hypercall1(int, physdev_op, physdev_op);
> +     return _hypercall2(int, physdev_op, cmd, physdev_op);
>  }
>  
>  static inline int



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel