Re: [Xen-devel] [PATCH 02/13 V6] remus: implement network buffering hotplug scripts

[Shriram Rajagopalan <rshriram@xxxxxxxxx>]

On Sun, Jan 26, 2014 at 11:06 PM, Wen Congyang <wency@xxxxxxxxxxxxxx> wrote:

At 01/27/2014 06:27 AM, Shriram Rajagopalan Wrote:
> On Tue, Jan 21, 2014 at 1:05 AM, Lai Jiangshan <laijs@xxxxxxxxxxxxxx> wrote:
>
>> From: Shriram Rajagopalan <rshriram@xxxxxxxxx>
>>
>> This patch introduces remus-netbuf-setup hotplug script responsible for
>> setting up and tearing down the necessary infrastructure required for
>> network output buffering in Remus.  This script is intended to be invoked
>> by libxl for each guest interface, when starting or stopping Remus.
>>
>> Apart from returning success/failure indication via the usual hotplug
>> entries in xenstore, this script also writes to xenstore, the name of
>> the IFB device to be used to control the vif's network output.
>>
>> The script relies on libnl3 command line utilities to perform various
>> setup/teardown functions. The script is confined to Linux platforms only
>> since NetBSD does not seem to have libnl3.
>>
>> Signed-off-by: Shriram Rajagopalan <rshriram@xxxxxxxxx>
>> Signed-off-by: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>
>> Reviewed-by: Wen Congyang <wency@xxxxxxxxxxxxxx>
>> ---
>>  tools/hotplug/Linux/Makefile           |   1 +
>>  tools/hotplug/Linux/remus-netbuf-setup | 183
>> +++++++++++++++++++++++++++++++++
>>  2 files changed, 184 insertions(+)
>>  create mode 100644 tools/hotplug/Linux/remus-netbuf-setup
>>
>>
> The last time I posted this script, the feedback was that the script and
> the code invoking
> the script should be in a single patch. So I would suggest doing the same.

We use the script in patch6. It adds 479 lines. These two patches are big
patches(add more than 100 lines), so why put them into a single patch?

That is a valid question. IIRC, IanJ was the one who wanted the code and the

script together. IanJ, any thoughts?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel