[Xen-devel] [PATCH] xen/events: xen_evtchn_fifo_init can be called very late

[Julien Grall <julien.grall@xxxxxxxxxx>]

On ARM, xen_init_IRQ (which calls xen_evtchn_fifo_init) is called after
all CPUs are online. It would mean that the notifier will never be called.

Therefore, when a secondary CPU will receive an interrupt, Linux will segfault
because the event channel structure for this processor is not initialized.

This can be fixed by calling the init function on every online cpu when the
event channel fifo driver is initialized.

Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
---
 drivers/xen/events/events_fifo.c |   11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/xen/events/events_fifo.c b/drivers/xen/events/events_fifo.c
index 1de2a19..15498ab 100644
--- a/drivers/xen/events/events_fifo.c
+++ b/drivers/xen/events/events_fifo.c
@@ -410,12 +410,14 @@ static struct notifier_block evtchn_fifo_cpu_notifier = {
 
 int __init xen_evtchn_fifo_init(void)
 {
-       int cpu = get_cpu();
+       int cpu;
        int ret;
 
-       ret = evtchn_fifo_init_control_block(cpu);
-       if (ret < 0)
-               goto out;
+       for_each_online_cpu(cpu) {
+               ret = evtchn_fifo_init_control_block(cpu);
+               if (ret < 0)
+                       goto out;
+       }
 
        pr_info("Using FIFO-based ABI\n");
 
@@ -423,6 +425,5 @@ int __init xen_evtchn_fifo_init(void)
 
        register_cpu_notifier(&evtchn_fifo_cpu_notifier);
 out:
-       put_cpu();
        return ret;
 }
-- 
1.7.10.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel