Re: [Xen-devel] [PATCH v2] xen/arm{32, 64}: fix section shift when mapping 2MB block in boot page table

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-01-14 at 06:19 +0800, Chen Baozi wrote:
>          ldr   r4, =BOOT_FDT_VIRT_START
> -        mov   r4, r4, lsr #18        /* Slot for BOOT_FDT_VIRT_START */
> +        mov   r4, r4, lsr #(SECOND_SHIFT)   /* Slot for BOOT_FDT_VIRT_START 
> */

Comparing the objdump before and after shows:
        @@ -299,7 +299,7 @@
           20041c:      e3822c0e        orr     r2, r2, #3584   ; 0xe00
           200420:      e382207d        orr     r2, r2, #125    ; 0x7d
           200424:      e3a04606        mov     r4, #6291456    ; 0x600000
        -  200428:      e1a04924        lsr     r4, r4, #18
        +  200428:      e1a04aa4        lsr     r4, r4, #21
           20042c:      e18120f4        strd    r2, [r1, r4]
           200430:      f57ff04f        dsb     sy
           200434:      e28f0004        add     r0, pc, #4
        
which I think is unexpected/incorrect. I think you wanted #(SECOND_SHIFT
- 3) as elsewhere.

The only other change to the binary was the expected s/20/21/ in both
arm32 and arm64.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel