Re: [Xen-devel] [PATCH v2] mini-os: Fix stubdom build failures on gcc 4.8

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-01-23 at 11:23 +0000, George Dunlap wrote:
> On 01/23/2014 11:06 AM, Ian Campbell wrote:
> > On Wed, 2014-01-22 at 11:41 -0600, xenmail43267@xxxxxxxxx wrote:
> >> From: Mike Neilsen <mneilsen@xxxxxxx>
> >>
> >> This is a fix for bug 35:
> >> http://bugs.xenproject.org/xen/bug/35
> >>
> >> This bug report describes several format string mismatches which prevent
> >> building the stubdom target in Xen 4.3 and Xen 4.4-rc2 on gcc 4.8.  This 
> >> is a
> >> copy of Alex Sharp's original patch with the following modifications:
> >>
> >> * Andrew Cooper's recommendation applied to extras/mini-os/xenbus/xenbus.c 
> >> to
> >>    avoid stack corruption
> >> * Samuel Thibault's recommendation to make "fun" an unsigned int rather 
> >> than an
> >>    unsigned long in pcifront_physical_to_virtual and related functions
> >>    (extras/mini-os/include/pcifront.h and extras/mini-os/pcifront.c)
> >>
> >> Tested on x86_64 gcc Ubuntu/Linaro 4.8.1-10ubuntu9.
> >>
> >> Signed-off-by: Mike Neilsen <mneilsen@xxxxxxx>
> >>
> >> ---
> >> Changed since v1:
> >> * Change "fun" arguments into unsigned ints
> >
> > Thanks for shaving that yakk! Since you've done it I obviously rescind
> > my previous comments ;-) (I should have read all my mail first).
> >
> > Acked-by: Ian Campbell <ian,campbell@xxxxxxxxxx>
> >
> > George -- as a build fix for a compiler which is now in the wild I think
> > this should go in for 4.4.
> 
> I agree.
> 
> Release-acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

Applied, thanks everyone.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel