[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] linux-2.6.18/usbback: fix after c/s 1232:8806dfb939d4


  • To: "xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: "Jan Beulich" <JBeulich@xxxxxxxx>
  • Date: Tue, 28 Jan 2014 12:28:49 +0000
  • Delivery-date: Tue, 28 Jan 2014 12:29:01 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

That c/s ("backends: Check for insane amounts of requests on the ring")
copied from blkback/blktap/scsiback a switch statement that is valid
there, but not here - the return value from usbbk_start_submit_urb()
could be any positive value, not just one.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- a/drivers/xen/usbback/usbback.c
+++ b/drivers/xen/usbback/usbback.c
@@ -1013,7 +1013,7 @@ static int usbbk_start_submit_urb(usbif_
 
        RING_FINAL_CHECK_FOR_REQUESTS(&usbif->urb_ring, more_to_do);
 
-       return more_to_do;
+       return !!more_to_do;
 }
 
 void usbbk_hotplug_notify(usbif_t *usbif, int portnum, int speed)



Attachment: xen-1232-fix.patch
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.