Re: [Xen-devel] [PATCH v2 3/4] xen/arm: clean and invalidate all guest caches by VMID after domain build.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-02-06 at 15:41 +0000, Julien Grall wrote:
> 
> On 06/02/14 15:04, Ian Campbell wrote:
> > On Thu, 2014-02-06 at 14:48 +0000, Julien Grall wrote:
> >>
> >> On 05/02/14 16:03, Ian Campbell wrote:
> >>      > +void sync_page_to_ram(unsigned long mfn)
> >>> +{
> >>> +    void *v = map_domain_page(mfn);
> >>> +
> >>> +    flush_xen_dcache_va_range(v, PAGE_SIZE);
> >>> +
> >>
> >> flush_xen_dcache_va_range uses DCCMVAC (for ARM32 bits), which only
> >> clean the cache.
> >>
> >> Following your commit message, we might want to use DCCIMVAC.
> >
> > Yes, I think you are right, I thought this function invalidated as well.
> 
> I was wondering if we can change the behaviour of 
> flush_xen_dcache_va_range. Invalidate the cache should not harm the 
> other call-site.

Perhaps, but not for 4.4.

I'm going to introduce clean_and_invalidate_xen_dcache and friends. 

Post 4.4 I'm also going to rename flush_xen_dcache_* to
clean_xen_dcache_* so I don't make this mistake again.

At that point we can consider where if anywhere moving from Clean to
Clean+Invalidate makes sense.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel