Re: [Xen-devel] [PATCH V2] x86/AMD: Apply workaround for AMD F16h Erratum792

[Aravind Gopalakrishnan <aravind.gopalakrishnan@xxxxxxx>]

On 2/6/2014 4:24 AM, Jan Beulich wrote:
> > > > On 05.02.14 at 22:43, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@xxxxxxx> 
> > > > wrote:
> > +
> >                 rdmsrl(MSR_AMD64_LS_CFG, value);
> >                 if (!(value & (1 << 15))) {
> >                         static bool_t warned;
> The patch context even shows what is missing: A diagnostic
> message making it possible to know that the workaround was
> applied. Of course you don't need two separate messages for
> the two parts of the workaround, but indicating in the message
> which of them was applied would seem desirable.
>
> Furthermore, I don't see why you would need a new local
> variable here at all - there are two suitable variables available
> throughout the entire function (l and h).
Okay, corrected the patch as per your comments.
Sending it out as V3.

-Aravind


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel