Re: [Xen-devel] [PATCH v4 3/5] xen/arm: clean and invalidate all guest caches by VMID after domain build.

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 7 Feb 2014, Ian Campbell wrote:
> > > +void sync_page_to_ram(unsigned long mfn)
> > > +{
> > > +    void *p, *v = map_domain_page(mfn);
> > > +
> > > +    dsb();           /* So the CPU issues all writes to the range */
> > > +    for ( p = v; p < v + PAGE_SIZE ; p += cacheline_bytes )
> > 
> > What about the last few bytes on a page?
> > Can we assume that PAGE_SIZE is a multiple of cacheline_bytes?
> 
> I sure hope so! A non power of two cache line size would be pretty
> crazy!
> 
> The cacheline is always a 2^N (the register contains log2(cacheline
> size)) and so is PAGE_SIZE.

Thought so.

For the Xen ARM side:

Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel