Re: [Xen-devel] [RFC 1/6] xen/arm: earlyprintk: move early_flush in early_puts

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Sun, 2014-01-05 at 21:26 +0000, Julien Grall wrote:
> early_puts function will be exported to be used in the console code. To
> avoid loosing characters (see why in commit cafdceb "xen/arm: avoid lost
> characters with early_printk), early_flush needs to be called in this
> function.
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> ---
>  xen/arch/arm/early_printk.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/xen/arch/arm/early_printk.c b/xen/arch/arm/early_printk.c
> index 41938bb..7143f9e 100644
> --- a/xen/arch/arm/early_printk.c
> +++ b/xen/arch/arm/early_printk.c
> @@ -29,12 +29,6 @@ static void __init early_puts(const char *s)
>          early_putch(*s);
>          s++;
>      }
> -}
> -
> -static void __init early_vprintk(const char *fmt, va_list args)
> -{
> -    vsnprintf(buf, sizeof(buf), fmt, args);
> -    early_puts(buf);
>  
>      /*
>       * Wait the UART has finished to transfer all characters before
> @@ -43,6 +37,12 @@ static void __init early_vprintk(const char *fmt, va_list 
> args)
>      early_flush();
>  }
>  
> +static void __init early_vprintk(const char *fmt, va_list args)
> +{
> +    vsnprintf(buf, sizeof(buf), fmt, args);
> +    early_puts(buf);
> +}
> +
>  void __init early_printk(const char *fmt, ...)
>  {
>      va_list args;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel