Re: [Xen-devel] [PATCH v2 5/6] xen/console: Add noreturn attribute to panic function

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 02/24/2014 03:24 PM, Jan Beulich wrote:
>>>> On 24.02.14 at 15:52, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
>> -void panic(const char *fmt, ...)
>> +void __attribute__((noreturn)) panic(const char *fmt, ...)
>>  {
>>      va_list args;
>>      unsigned long flags;
>> @@ -1085,6 +1085,8 @@ void panic(const char *fmt, ...)
>>          watchdog_disable();
>>          machine_restart(5000);
>>      }
>> +
>> +    while ( 1 );
> 
> The canonical thing here would be "for ( ; ; );", since there are
> compilers warning about the literal 1 in what you propose.

With Andrew's patch series I don't need this patch anymore. I will drop it.

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel