[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 03/10 V7] tools/libxl: introduce a new structure libxl__remus_state

Lai Jiangshan writes ("[PATCH 03/10 V7] tools/libxl: introduce a new structure 
> libxl_domain_remus_info only contains the argument of the command
> 'xl remus'. So introduce a new structure libxl__remus_state to save
> the remus state.

I appreciate that you've probably split this up to try to make the
review easier, but I think there would probably be a way to do this
that made the patches make more sense when reviewed in isolation.

For this one:

> +    /* convenience shorthand */
> +    libxl__remus_state *remus_state = dss->remus_state;
> +    remus_state->blackhole = info->blackhole;
> +    remus_state->interval = info->interval;
> +    remus_state->compression = info->compression;
> +    remus_state->dss = dss;
> +    libxl__ev_child_init(&remus_state->child);

AFAICT the main point of this patch seems to be to copy a bunch of
configuration options from libxl_domain_remus_start's info argument
into dss->remus_state.

I don't understand why this is desirable.  Does the info argument not
have a sufficient lifetime ?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.