Re: [Xen-devel] [PATCH 10/10 V7] libxl: network buffering cmdline switch

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Lai Jiangshan writes ("[PATCH 10/10 V7] libxl: network buffering cmdline 
switch"):
> From: Shriram Rajagopalan <rshriram@xxxxxxxxx>
> 
> Command line switch to 'xl remus' command, to enable network buffering.
> Pass on this flag to libxl so that it can act accordingly.
> Also update man pages to reflect the addition of a new option to
> 'xl remus' command.
> 
> Note: the network buffering is enabled as default. If you want to
> disable it, please use -n option.
...
> diff --git a/docs/man/xl.conf.pod.5 b/docs/man/xl.conf.pod.5
> index 7c43bde..8ae19bb 100644
> --- a/docs/man/xl.conf.pod.5
> +++ b/docs/man/xl.conf.pod.5
> @@ -105,6 +105,12 @@ Configures the default gateway device to set for virtual 
> network devices.
>  
>  Default: C<None>
>  
> +=item B<remus.default.netbufscript="PATH">
> +
> +Configures the default script used by Remus to setup network buffering.

You provide a global option to control the script, but no per-domain
config option.  Why ?

> @@ -7287,6 +7294,9 @@ int main_remus(int argc, char **argv)
>      domid = find_domain(argv[optind]);
>      host = argv[optind + 1];
>  
> +    if(!r_info.netbufscript)
         ^
Coding style (missing space).

...
> +    if (libxl_domain_info(ctx, 0, domid)) {
> +        fprintf(stderr, "Remus: Primary domain has been destroyed.\n");
> +        close(send_fd);
> +        return 0;

You should not assume that any error means that the domain has been
destroyed.  Rather you should check the error code.

>  > +    /* If we are here, it means remus setup/domain suspend/backup has
> +     * failed. Try to resume the domain and exit gracefully.
> +     * TODO: Split-Brain check.

What are your plans for the split brain check ?

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel