[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] tools/libxc: Avoid hypercalls for cacheflush on x86
>>> On 03.03.14 at 15:37, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote: > --- a/tools/libxc/xc_domain.c > +++ b/tools/libxc/xc_domain.c > @@ -51,12 +51,18 @@ int xc_domain_create(xc_interface *xch, > int xc_domain_cacheflush(xc_interface *xch, uint32_t domid, > xen_pfn_t start_pfn, xen_pfn_t nr_pfns) > { > +#if defined (__i386__) || defined (__x86_64__) > + /* This is not implemented or needed for x86. Avoid repeatedly going to > + * Xen to find -ENOSYS. */ > + return -ENOSYS; Leaving aside the question of whether this is worthwhile in the first place, this is wrong: You want to return -1 here, setting errno to ENOSYS. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |