Re: [Xen-devel] [RFC PATCHv1] serial: Support OXPCIe952 aka Oxford Semiconductor Ltd Device c138 (1415:c138)

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.03.14 at 03:01, Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx> wrote:
> @@ -325,11 +342,12 @@ static void __init ns16550_init_preirq(struct 
> serial_port *port)
>  #ifdef CONFIG_X86
>          enum fixed_addresses idx = FIX_COM_BEGIN + (uart - ns16550_com);
>  
> -        set_fixmap_nocache(idx, uart->io_base);
> +        set_fixmap_nocache(idx, uart->io_base + uart->offset);
>          uart->remapped_io_base = (void __iomem *)fix_to_virt(idx);
>          uart->remapped_io_base += uart->io_base & ~PAGE_MASK;

Don't you need to add in uart->offset here too?

>  #else
> -        uart->remapped_io_base = (char *)ioremap(uart->io_base, 
> uart->io_size);
> +        uart->remapped_io_base = (char *)ioremap(uart->io_base+ uart->offset,

Missing space.

> +                                                 uart->io_size);
>  #endif
>      }
>  

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel