Re: [Xen-devel] [PATCH 2/2] xl: Add "seize" option to PCI devices

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

George Dunlap writes ("Re: [PATCH 2/2] xl: Add "seize" option to PCI devices"):
> While I'm here, might as well ask: I was going back and forth on this 
> one, whether "seize" should actually be something passed in via the pci 
> struct, as it's not really a property of the pci device itself.  Other 
> options would be:
> 1. Keep it out of libxl entirely: have the toolstack (in this case xl) do it
> 2. Have it done in libxl's domain creation
> 3. Make it an extra argument to libxl_pci_add()
> 
> When having my initial "second thoughts", #1 seemed most reasonable. 
> But I'm not aware of any other such options handled in xl at the moment; 
> this would be the only example of such an option.

It should definitely be in the pci struct.  These libxl structs all
specify not just how the device should appear in the guest, but also
the host resources which are to be used.  To my mind that very much
includes the manner in which the host resource allocation is to be
done (such as whether or not to automatically seize the device).

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel