[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 3/8] qspinlock, x86: Add x86 specific optimization for 2 contending tasks

On 03/02/2014 08:16 AM, Oleg Nesterov wrote:
On 02/26, Waiman Long wrote:
@@ -144,7 +317,7 @@ static __always_inline int queue_spin_setlock(struct 
qspinlock *lock)
        int qlcode = atomic_read(lock->qlcode);

        if (!(qlcode&  _QSPINLOCK_LOCKED)&&  (atomic_cmpxchg(&lock->qlcode,
-               qlcode, qlcode|_QSPINLOCK_LOCKED) == qlcode))
+               qlcode, code|_QSPINLOCK_LOCKED) == qlcode))
Hmm. didn't read the patch, but this change looks like accidental typo...


Thank for catching that typo error. That generic code wasn't compiled in and so I missed it. I will fix that in the next version.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.