[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH net-next v6 1/10] xen-netback: Use skb->cb for pending_idx

On 05/03/14 12:16, Wei Liu wrote:
On Tue, Mar 04, 2014 at 10:32:12PM +0000, Zoltan Kiss wrote:
Storing the pending_idx at the first byte of the linear buffer never looked
good, skb->cb is a more proper place for this. It also prevents the header to
be directly grant copied there, and we don't have the pending_idx after we
copied the header here, so it's time to change it.

I think this is a valid change. But I would like you to define a
skb_cb_overlay just like the receive path does.

You can rename skb_cb_overlay in current code to skb_cb_overlay_rx and
add your skb_cb_overlay_tx.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.