Re: [Xen-devel] [PATCH v1 3/4] serial: Use #defines for PCI vendor and models

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.03.14 at 18:25, Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx> wrote:
> --- a/xen/drivers/char/ns16550.c
> +++ b/xen/drivers/char/ns16550.c
> @@ -131,17 +131,21 @@ static struct ns16550_config_quirk __initdata 
> uart_quirk[] = {
>          .max_bars = 1, /* It can do more, but we would need more custom 
> code.*/
>      }
>  };
> +
> +#define PCI_VENDOR_ID_BROADCOM           0x14e4
> +#define PCI_DEVICE_ID_BROADCOM_TRUMANAGE 0x160a
> +#define PCI_VENDOR_ID_OXSEMI             0x1415
>  static struct ns16550_config_mmio __initdata uart_config[] =
>  {
>      /* Broadcom TruManage device */
>      {
> -        .vendor_id = 0x14e4,
> -        .dev_id = 0x160a,
> +        .vendor_id = PCI_VENDOR_ID_BROADCOM,
> +        .dev_id = PCI_DEVICE_ID_BROADCOM_TRUMANAGE,
>          .quirk = quirk_trumanage,
>      },
>      /* OXPCIe952 1 Native UART  */
>      {
> -        .vendor_id = 0x1415,
> +        .vendor_id = PCI_VENDOR_ID_OXSEMI,
>          .dev_id = 0xc138,

And why not for this one?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel