Re: [Xen-devel] [PATCH v3] x86/time: Always count s_time from Xen boot

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.03.14 at 17:01, Tim Deegan <tim@xxxxxxx> wrote:
> @@ -203,6 +209,10 @@ GLOBAL(trampoline_end)
>  __high_start:
>  #include "x86_64.S"
>  
> +        .section .init.data, "a", @progbits
> +GLOBAL(boot_tsc_stamp)
> +        .quad   0

I think it would be better to have that definition in the C file, ...

> --- a/xen/arch/x86/time.c
> +++ b/xen/arch/x86/time.c
> @@ -84,6 +84,9 @@ static u16 pit_stamp16;
>  static u32 pit_stamp32;
>  static bool_t __read_mostly using_pit;
>  
> +/* Boot timestamp, filled in head.S (initdata) */
> +extern u64 boot_tsc_stamp;

... instead of only declaring it here.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel