[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v1 4/4] serial: Expand the PCI serial quirks for OXPCIe200 and OXPCIe952 1 Native UART

>>> On 07.03.14 at 16:55, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote:
> On Thu, Mar 06, 2014 at 10:20:47AM +0000, Jan Beulich wrote:
>> >>> On 05.03.14 at 18:25, Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx> wrote:
>> > This covers all of the OXPCIe952 1 Native UART and
>> > OXPCIe200 1 Native UART chipsets.
>> With this I can certainly see why you didn't give the single ID a
>> name in the previous patch. But let's be consistent then and have
>> - for now at least - only vendor IDs have (global, as Andrew
>> validly suggested) manifest constants.
> Do you want that just for the serial driver or for all?

Ultimately for the whole tree, but I'm not necessarily asking you
to do this in one go. Whatever you have available would be a
good starting point. I.e. what you have should be fine to go
(albeit as said I'm not sure we really want/need device IDs
there - it's more the exception than the rule to need the same
device ID in more than one place), with one request for change:

> --- /dev/null
> +++ b/xen/include/xen/pci_devs.h

Please name this pci_ids.h, to match Linux.

> @@ -0,0 +1,17 @@
> +#ifndef XEN_PCI_DEVS_H_
> +#define XEN_PCI_DEVS_H

And please along with adjusting this for the changed name fix the
discrepancy in spelling. In fact we don't really need a guard in this
header, since it only consists of #define-s (see Linux'es), so you
might as well drop it.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.