Re: [Xen-devel] [PATCH v5 1/5] xen/time: Move wallclock_time() declaration into common code

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-03-07 at 17:28 +0000, Andrew Cooper wrote:
> It is called from common code, but has architecture specific implementations.
> Have one declaration instead of two.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Keir Fraser <keir@xxxxxxx>
> CC: Jan Beulich <JBeulich@xxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
> CC: Tim Deegan <tim@xxxxxxx>
> ---
>  xen/include/asm-arm/time.h |    3 ---
>  xen/include/asm-x86/time.h |    3 ---
>  xen/include/xen/time.h     |    1 +
>  3 files changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/xen/include/asm-arm/time.h b/xen/include/asm-arm/time.h
> index 9d302d3..d10c737 100644
> --- a/xen/include/asm-arm/time.h
> +++ b/xen/include/asm-arm/time.h
> @@ -12,9 +12,6 @@ static inline cycles_t get_cycles (void)
>          return 0;
>  }
>  
> -struct tm;
> -struct tm wallclock_time(void);
> -
>  /* List of timer's IRQ */
>  enum timer_ppi
>  {
> diff --git a/xen/include/asm-x86/time.h b/xen/include/asm-x86/time.h
> index 147b39e..c01b0a2 100644
> --- a/xen/include/asm-x86/time.h
> +++ b/xen/include/asm-x86/time.h
> @@ -48,9 +48,6 @@ int dom0_pit_access(struct ioreq *ioreq);
>  
>  int cpu_frequency_change(u64 freq);
>  
> -struct tm;
> -struct tm wallclock_time(void);
> -
>  void pit_broadcast_enter(void);
>  void pit_broadcast_exit(void);
>  int pit_broadcast_is_available(void);
> diff --git a/xen/include/xen/time.h b/xen/include/xen/time.h
> index 95b4b91..3eb5b63 100644
> --- a/xen/include/xen/time.h
> +++ b/xen/include/xen/time.h
> @@ -48,6 +48,7 @@ struct tm {
>      int     tm_isdst;       /* daylight saving time */
>  };
>  struct tm gmtime(unsigned long t);
> +struct tm wallclock_time(void);
>  
>  #define SYSTEM_TIME_HZ  1000000000ULL
>  #define NOW()           ((s_time_t)get_s_time())



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel