[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 2/2] Add a "make rpmball" target

On Mon, 2014-03-10 at 16:31 +0000, George Dunlap wrote:
> On 03/10/2014 04:27 PM, Ian Jackson wrote:
> > George Dunlap writes ("[PATCH v3 2/2] Add a "make rpmball" target"):
> >> Build a simplistic dummy package, similar to "make debball", for
> >> developers on rpm-based systems.
> > This is obviously a good thing to have but I'll wait for feedback
> > before committing this as I can't easily test it myself.
> Well given that I can't test things on Don's system either, it may be 
> more sensible to check this in as it is, and allow him to fix it so that 
> it works for him.

Personally I think this is a sensible approach, plus it looks like Don
has now tested it and it works, so good.

I've glanced at it, but I don't think this sort of thing needs
especially thorough review so:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> (Although then it may break for me, but we can hope that later versions 
> of rpmbuild are more likely to be compatible with earlier versions...)
>   -George

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.