Re: [Xen-devel] [PATCH net] xen-netback: use skb_is_gso in xenvif_start_xmit

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-03-11 at 12:45 +0000, Wei Liu wrote:
> In 5bd076708 ("Xen-netback: Fix issue caused by using gso_type wrongly")
> we use skb_is_gso to determine if we need an extra slot to accommodate
> the SKB. There's similar error in interface.c. Change that to use
> skb_is_gso as well.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Cc: Annie Li <annie.li@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> Cc: Paul Durrant <paul.durrant@xxxxxxxxxx>
> ---
>  drivers/net/xen-netback/interface.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/xen-netback/interface.c 
> b/drivers/net/xen-netback/interface.c
> index 7669d49..301cc03 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -132,8 +132,7 @@ static int xenvif_start_xmit(struct sk_buff *skb, struct 
> net_device *dev)
>       /* If the skb is GSO then we'll also need an extra slot for the
>        * metadata.
>        */
> -     if (skb_shinfo(skb)->gso_type & SKB_GSO_TCPV4 ||
> -         skb_shinfo(skb)->gso_type & SKB_GSO_TCPV6)
> +     if (skb_is_gso(skb))
>               min_slots_needed++;
>  
>       /* If the skb can't possibly fit in the remaining slots



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel