Re: [Xen-devel] [PATCH] tools/xcutils: Free xlt loggers after use

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-03-11 at 13:51 +0000, Andrew Cooper wrote:
> On 11/03/14 13:25, Ian Campbell wrote:
> > On Mon, 2014-03-10 at 17:06 +0000, Andrew Cooper wrote:
> >> While not much of a functional change, this prevents irritating warnings 
> >> from
> >> valgrind when trying to analyse xc_domain_{save,restore}() themselves.
> > Are you trying to valgrind xend or something? (I thought these were
> > exclusively used by xend).
> >>  tools/xcutils/xc_restore.c |    1 +
> >>  tools/xcutils/xc_save.c    |    1 +
> >>  2 files changed, 2 insertions(+)
> > Ian.
> >
> >
> 
> I am developing the migration stream v2, and using xc_save/restore as
> thin wrappers around xc_domain_save/restore(), where I can dump the
> intermediate stream to a file and verify it for correctness.

Ah, useful!

I suspect you could also achieve this by providing xl migrate with a
custom -s command which involved a tee as well as a ssh, but you may as
well stick with what you've got.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel