[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 06/13] xen/passthrough: iommu: Split generic IOMMU code

>>> On 11.03.14 at 16:49, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> +static int iommu_populate_page_table(struct domain *d)
> +{

I continue to be of the opinion that this is misplaced here. There's
nothing PCI-related in this function, and I doubt you can get away
on ARM without similar code (if you can, this should go into
.../x86/iommu.c imo).

> --- /dev/null
> +++ b/xen/include/asm-x86/iommu.h
> +void iommu_set_dom0_mapping(struct domain *d);

How is this x86-specific?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.