[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [RFC PATCH v2 1/1] Add pci_hole_min_size
On 03/11/2014 03:27 PM, Don Slutz wrote: Add logging of max_ram_below_4g too big. Is this the whole commit message? This looks more like v2 vs. v1 diff description. I think you need to put most of the text from your 0/1 message here. Signed-off-by: Don Slutz <dslutz@xxxxxxxxxxx> --- ... diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index 5c06dfa..72842aa 100644 --- a/tools/libxl/libxl_dm.c +++ b/tools/libxl/libxl_dm.c @@ -656,6 +656,21 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc, } else { flexarray_append(dm_args, "xenfv"); } + if (b_info->u.hvm.pci_hole_min_size) { + unsigned long long max_ram_below_4g = (1ULL << 32) - + b_info->u.hvm.pci_hole_min_size; + + if (max_ram_below_4g > 0xF0000000ULL) Is this '>' or '<'? + { + LIBXL__LOG(ctx, LIBXL__LOG_WARNING, + "pci_hole_min_size too big => max_ram_below_4g=%llu > %llu (new adjusted value)\n", + max_ram_below_4g, 0xF0000000ULL); + max_ram_below_4g = 0xF0000000ULL; Do you need to adjust pci_hole_min_size as well? -boris + } + flexarray_append_pair(dm_args, "-global", + GCSPRINTF("pc-memory-layout.max-ram-below-4g=%llu", + max_ram_below_4g)); + } for (i = 0; b_info->extra_hvm && b_info->extra_hvm[i] != NULL; i++) flexarray_append(dm_args, b_info->extra_hvm[i]); break; _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |