[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] systemd: add support initial systemd service files
On 03/12/14 09:35, Luis R. Rodriguez wrote: > On Wed, Mar 12, 2014 at 1:16 AM, Jacek Konieczny <jajcus@xxxxxxxxxx> wrote: >> On 03/12/14 01:03, Luis R. Rodriguez wrote: >>> From: "Luis R. Rodriguez" <mcgrof@xxxxxxxx> >>> >>> I've tested these on an OpenSUSE Tumbleweed source install. >>> They are based on the ones from OpenSUSE but slightly modified. >> >> These seems quite wrong to me. Why create systemd services, while they >> are only wrappers to the old-style LSB scripts? What do we gain? > > Huh? LSB? Systemd is here to stay. I don't see what you are trying to > say with LSB stuff. I just didn't want to abuse the 'System V init' term for these: https://refspecs.linuxfoundation.org/LSB_2.1.0/LSB-generic/LSB-generic/iniscrptact.html (System V init only uses /etc/inittab, the 'init.d' scripts are later invention) >> Systemd provides great process control and monitoring, but it can only >> do that if it starts the process by itself â it knows the main PID then, >> knows if the service is running, etc. > > Now that sounds like a reasonable constructive argument to NACK a > patch, can you provide pointers to one service file that does that > properly as you are suggesting? This is what we have inPLD Linux (currently for Xen 4.3.2), probably based on work from some other distro (Fedora, I guess): https://github.com/pld-linux/xen/blob/master/xen-watchdog.service https://github.com/pld-linux/xen/blob/master/xenconsoled.service https://github.com/pld-linux/xen/blob/master/xendomains.service https://github.com/pld-linux/xen/blob/master/xenstored.service It may be not perfect, nor ready for inclusion in the upstream Xen, but I think this is the way to go. They may also need updates for current Xen. > Seems like you can provide a much better set of suitable scripts, mind > just taking them and fixing them or would you like me to take your > advice steps by step? Feel free to take those scripts. Unfortunately, I won't be able to prepare a ready patch for Xen by myself. Cc: Jan RÄkorajski, who committed the first version of our systemd units. Greets, Jacek _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |