Re: [Xen-devel] [PATCH] systemd: add support initial systemd service files

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-03-12 at 11:14 +0000, Ian Jackson wrote:
> Jacek Konieczny writes ("Re: [Xen-devel] [PATCH] systemd: add support initial 
> systemd service files"):
> > These seems quite wrong to me. Why create systemd services, while they
> > are only wrappers to the old-style LSB scripts? What do we gain?
> 
> I agree with this criticism.
> 
> > The right thing to do is to provide separate systemd unit for xenstored
> > and xenconsoled.
> 
> If we do this then things will break if we add new functionality to
> xencommons.  We would have to ask contributors who added new code to
> xencommons to update the systemd unit files.  Those contributors, and
> we, might not be able to test them (or alternatively wouldn't test the
> sysvinit scripts).

I hadn't thought of this aspect, it is a concern.

On the other hand if systemd using distros are carrying their own
service files then each of them will be rediscovering the issues
themselves, possibly after we've triaged it here for the Nth time. Even
if the set of upstream service files are not kept completely up to date
at least they are in a common location, with some >0 chance of getting
update when things change.

I'm not sure which way I am leaning right now.

> Perhaps, until there is some way to generate all of this configuration
> from a single input, it would be best for the upstream tree to
> continue to provide just sysvinit scripts.
> 
> Thanks,
> Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel