Re: [Xen-devel] 4.4.0-rc3 tagged

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-02-10 at 11:59 +0100, Roger Pau Monnà wrote:
> The Ocaml autoconf stuff was picked from http://forge.ocamlcore.org/. 
> Here is an untested patch for our configure script to check for the 
> minimum required OCaml version (3.09.3):

Did you ever get round to testing this?

I also wonder if we should be testing for the first version we support,
rather than the last version we didn't. Maybe that's splitting hairs a
bit though.

> 
> (remember to re-generate the configure script after applying)
> 
> ---
> commit e49609cc7b93c2633cf5a49206cb29d6bdd612be
> Author: Roger Pau Monne <roger.pau@xxxxxxxxxx>
> Date:   Mon Feb 10 11:54:13 2014 +0100
> 
>     tools: check OCaml version is at least 3.09.3
>     
>     Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> 
> diff --git a/tools/configure.ac b/tools/configure.ac
> index 0754f0e..6d1e2ee 100644
> --- a/tools/configure.ac
> +++ b/tools/configure.ac
> @@ -161,6 +161,12 @@ AS_IF([test "x$ocamltools" = "xy"], [
>          AS_IF([test "x$enable_ocamltools" = "xyes"], [
>              AC_MSG_ERROR([Ocaml tools enabled, but unable to find Ocaml])])
>          ocamltools="n"
> +    ], [
> +        AX_COMPARE_VERSION([$OCAMLVERSION], [lt], [3.09.4], [
> +            AS_IF([test "x$enable_ocamltools" = "xyes"], [
> +                AC_MSG_ERROR([Your version of OCaml: $OCAMLVERSION is not 
> supported])])
> +            ocamltools="n"
> +        ])
>      ])
>  ])
>  AS_IF([test "x$xsmpolicy" = "xy"], [
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel