[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.5 2/8] xen/arm: setup_dt_irq: don't enable the IRQ if the creation has failed

On Wed, 2014-02-19 at 11:24 +0000, Ian Campbell wrote:
> On Fri, 2014-01-24 at 16:43 +0000, Julien Grall wrote:
> > For now __setup_dt_irq can only fail if the action is already set. If in the
> > future, the function is updated we don't want to enable the IRQ.
> > 
> > Assuming the function can fail with action = NULL, when Xen will receive the
> > IRQ it will segfault because do_IRQ doesn't check if action is NULL.
> > 
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

applied just this one for now. I'm picking up trivial looking stuff from
my queue I'll revisit the rest in my next pass.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.