Re: [Xen-devel] [PATCH 02/11] unmodified_drivers: remove ia64 parts of the code

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.03.14 at 15:26, Olaf Hering <olaf@xxxxxxxxx> wrote:
> On Wed, Mar 12, Jan Beulich wrote:
> 
>> >>> On 06.03.14 at 17:13, Olaf Hering <olaf@xxxxxxxxx> wrote:
>> > Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
>> > ---
>> >  .../linux-2.6/compat-include/xen/platform-compat.h |  4 ---
>> >  unmodified_drivers/linux-2.6/mkbuildtree           | 16 +---------
>> >  unmodified_drivers/linux-2.6/overrides.mk          |  3 --
>> >  unmodified_drivers/linux-2.6/platform-pci/Kbuild   |  4 ---
>> >  .../linux-2.6/platform-pci/panic-handler.c         | 14 ---------
>> >  .../linux-2.6/platform-pci/platform-pci.c          | 23 --------------
>> >  .../linux-2.6/platform-pci/xen_support.c           | 36 
> ----------------------
>> >  7 files changed, 1 insertion(+), 99 deletions(-)
>> 
>> Why? In fact I think it was a mistake too to remove the ia64 bits
>> from the public headers - there's nothing wrong with someone
>> still wanting to build ia64 PV drivers against an old Linux tree (e.g.
>> linux-2.6.18-xen.hg itself, where I intentionally avoided mirroring
>> that public header cleanup), and the implementation going away
>> is unrelated to the interface definitions remaining the same.
> 
> Wouldnt they pick 4.3 or older for that task, given that there are no
> relevant changes?

As long as there are no relevant changes, sure. The moment some
bug fix shows up, this could change.

> But I'm fine with dropping that patch.

Please do, at least until we decided whether the related public
header pruning was premature.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel