[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 4/5] xen/console: Add support for early printk



Hi Jan,

On 03/12/2014 03:20 PM, Jan Beulich wrote:
>>>> On 12.03.14 at 15:34, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
>> --- /dev/null
>> +++ b/xen/include/xen/early_printk.h
>> @@ -0,0 +1,21 @@
>> +/*
>> + * printk() for use before the console is initialized
>> + */
>> +#ifndef __XEN_EARLY_PRINTK_H__
>> +#define __XEN_EARLY_PRINTK_H__
>> +
>> +#ifdef CONFIG_EARLY_PRINTK
>> +void early_puts(const char *s);
>> +#else
>> +static inline void early_puts(const char *s) {};
> 
> Considering that the only (source) use of the function is to take its
> address, using an inline function for that purpose is bogus. Either
> #define it to NULL (thus leaving the serial_steal_fn initializer
> unchanged for x86) or have it be a static __init function in
> xen/drivers/char/console.c, conditional upon !CONFIG_EARLY_PRINTK.

Right, I will fix it for the next version of this patch.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.