[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/5] xen/x86: Cleanup use of __attribute__((packed))

>>> On 13.03.14 at 12:00, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> On 13/03/14 08:32, Jan Beulich wrote:
>> But then again I can't see why the attribute would be needed here
>> in the first place.
> As indicated, I was overly hesitant with bitfields, but perhaps overly.

Since that's the only thing we care of, perhaps add a
BUILD_BUG_ON(sizeof(union segment_attributes) != 2) somewhere
where it doesn't conflict with the tools/tests/ use, but the type is in

> Alright - All hardware interfaces can keep their redundant __packed,
> which also serves partly as documentation.
> One interesting question George raises is whether the trace record
> format should be count as well?  It is just a software interface, but
> mixing __packed on different record structures seems a little inconsistent.

And I agree with that - it is an interface specification (even if
scattered around awkwardly) after all.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.