[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2] tools/mfndump: Avoid unintentional NULL dereference
On gio, 2014-03-13 at 11:09 +0000, Andrew Cooper wrote: > If we failed to open an xc interface, using xch to log an error will end in > tears. Print to stderr instead, as we are bailing immediately later. > > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> > Coverity-id: 1191885 > Acked-by: Ian Campbell <Ian.Campbell@xxxxxxxxxx> > CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> > CC: Dario Faggioli <dario.faggioli@xxxxxxxxxx> > If this is not yet in, feel free to add: Acked-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx> Because, I confirm, I did unintentionally and not deliberately! :-P > v2: Reword subject > > This is why macros depending on variables in scope, particularly ones named > as simily as "ERROR", are evil. > I Could not agree more! Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) Attachment:
signature.asc _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |