Re: [Xen-devel] [RFC 08/14] xen/xsm: flask: Rename variable "bool" in "b"

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.03.14 at 14:17, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> Hi Andrew,
> 
> On 03/12/2014 04:26 PM, Andrew Cooper wrote:
>> On 12/03/14 16:16, Julien Grall wrote:
>>> On ARM, the compilation is failing with the following error:
>>> In file included from flask_op.c:21:0:
>>> ./include/conditional.h:24:43: error: two or more data types in declaration 
> specifiers
>>> ./include/conditional.h:25:42: error: two or more data types in declaration 
> specifiers
>>>
>>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
>>> Cc: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
>> 
>> I am curious as to why this works on x86.  The name 'bool' is specified
>> as an alias for '_Bool' by C99/stdboot.h
> 
> It's because ARM include indirectly stdbool.h via xen/device_tree.h.
> I've tried to add "#include <xen/stdbool.h>" in conditional.h and I get
> the same compilation error.

And (at least so far) this isn't intended to be included by arbitrary
code, it exists solely to support code shared with the tools (e.g.
common/libelf/). Which isn't to say that I mind the change - it's
valid cleanup after all.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel