[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 1/5] xen/misc: Functional cleanup for __attribute__((packed)) changes
On 13/03/14 16:22, Jan Beulich wrote: >>>> On 13.03.14 at 16:04, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote: >> --- a/xen/arch/x86/cpu/mcheck/mce-apei.c >> +++ b/xen/arch/x86/cpu/mcheck/mce-apei.c >> @@ -53,7 +53,7 @@ struct cper_mce_record { >> struct cper_record_header hdr; >> struct cper_section_descriptor sec_hdr; >> struct mce mce; >> -} __packed; >> +} __attribute__((packed)); >> /* Reset to default packing */ >> #pragma pack() > I'm sorry for paying attention only now, but you apparently didn't > notice this either: The #pragma pack() around that structure was > the apparent attempt to deal with __packed "not functioning". We > should get rig of these pragmas at the same time I think. > > Jan > I did notice that, but was hoping to ignore it for the time being (as this __packed series has become rather longer than the half hour task I planned it to be) I shall do a new following patch which replaces the use of #pragma pack() in Xen, which doesn't look too difficult. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |