Re: [Xen-devel] [PATCH 08/19] libxc: suspend: Fix suspend event channel locking

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-03-04 at 14:56 +0000, Ian Jackson wrote:
> Use fcntl F_SETLK, rather than writing our pid into a "lock" file.
> That way if we crash we don't leave the lockfile lying about.  Callers
> now need to keep the fd for our lockfile.  (We don't use flock because
> we don't want anyone who inherits this fd across fork to end up with a
> handle onto the lock.)
> 
> While we are here:
>  * Move the lockfile to /var/run/xen

There isn't some autoconf'y path we should use is there? SUBSYS_DIR,
localstatedir etc?

Probably we don't really use those elsewhere so it is consistent to
use /var directly here too.

>  * De-duplicate the calculation of the pathname
>  * Compute the buffer size for the pathname so that it will definitely
>    not overrun (and use the computed value everywhere)
>  * Fix various error handling bugs
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> CC: Shriram Rajagopalan <rshriram@xxxxxxxxx>
> ---
>  tools/libxc/xc_suspend.c                           |  159 
> +++++++++++++-------
>  tools/libxc/xenguest.h                             |   16 +-
>  tools/libxl/libxl_dom.c                            |    6 +-
>  tools/libxl/libxl_internal.h                       |    1 +
>  tools/misc/xen-hptool.c                            |   19 ++-
>  tools/python/xen/lowlevel/checkpoint/checkpoint.h  |    2 +-
>  .../python/xen/lowlevel/checkpoint/libcheckpoint.c |    7 +-
>  tools/xcutils/xc_save.c                            |    8 +-
>  8 files changed, 149 insertions(+), 69 deletions(-)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel