Re: [Xen-devel] [PATCH 09/19] libxl: suspend: Async libxl__domain_suspend_callback

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-03-04 at 14:56 +0000, Ian Jackson wrote:
> Mark the suspend callback libxl__domain_suspend_callback as
> asynchronous in the helper stub generator (libxl_save_msgs_gen.pl).
> We are going to want to provide an asynchronous version of this
> function to get rid of the usleeps and waiting loops in the suspend
> code.
> 
> libxl__domain_suspend_common_callback, the common synchronous core,
> which used to be provided directly as the callback function for the
> helper machinery, becomes libxl__domain_suspend_callback_common.  It
> can now take a typesafe parameter.
> 
> For now, provide two 

two == remus & regular?

> very similar asynchronous wrappers for it.  Each
> is a simple function which contains only boilerplate, calls the common
> synchronous core, and returns the asynchronous response.
> 
> Essentially, we have just moved (in the case of suspend callbacks) the
> call site of libxl__srm_callout_callback_complete.

Do you mean libxl__srm_callout_sendreply here?

>   It was in the
> switch statement in the autogenerated _libxl_save_msgs_callout.c, and
> is now in the handwritten libxl_dom.c.
> 
> No functional change.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> Cc: Shriram Rajagopalan <rshriram@xxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel