Re: [Xen-devel] [PATCH 13/19] libxl: suspend: New domain_suspend_pvcontrol_acked

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-03-04 at 14:56 +0000, Ian Jackson wrote:
> Factor out domain_suspend_pvcontrol_acked.
> 
> This replaces a bunch of open-coded strcmp()s and makes the code
> clearer.  It also eliminates the need to check for state==NULL each
> time it's read, because we can check for NULL once before the strcmp.
> 
> No functional change.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---
>  tools/libxl/libxl_dom.c |   17 ++++++++++-------
>  1 file changed, 10 insertions(+), 7 deletions(-)
> 
> diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> index 59f6ce3..a0b3a57 100644
> --- a/tools/libxl/libxl_dom.c
> +++ b/tools/libxl/libxl_dom.c
> @@ -1034,6 +1034,12 @@ static void domain_suspend_common_done(libxl__egc *egc,
>                                         libxl__domain_suspend_state *dss,
>                                         bool ok);
>  
> +static bool domain_suspend_pvcontrol_acked(const char *state) {
> +    /* any value other than "suspend", including ENOENT, is OK */

Where ENOENT is indicated by !state I suppose?

Assuming so you can mention that here if you like, either way:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel