Re: [Xen-devel] [PATCH 2/2] tools/xc: pass errno to callers of xc_domain_save [and 1 more messages]

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Olaf Hering writes ("[PATCH 2/2] tools/xc: pass errno to callers of 
xc_domain_save"):
> Callers of xc_domain_save use errno to print diagnostics if the call
> fails. But xc_domain_save does not preserve the actual errno in case of
> a failure.

I think this patch is responsible for this regresssion:

xen.org writes ("[xen-unstable test] 25406: regressions - FAIL"):
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>  test-amd64-i386-freebsd10-amd64 10 guest-saverestore  fail REGR. vs. 25400

libxl-save-helper: xc_domain_save.c:2045: xc_domain_save: Assertion `rc' failed.
libxl: error: libxl_utils.c:396:libxl_read_exactly: file/stream truncated 
reading ipc msg header from domain 1 save/restore helper stdout pipe
libxl: error: libxl_exec.c:129:libxl_report_child_exitstatus: domain 1 
save/restore helper [-1] died due to fatal signal Aborted

I think this demonstrates the value of including that assertion :-).

Olaf, are you able to investigate this and fix it ?  The pattern of
failures suggests it's an HVM-only problem.  See the full test report
for flight 25406 for more info.

Thanks,
Ian.

From: xen.org <Ian.Jackson@xxxxxxxxxxxxx>
To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
CC: <ian.jackson@xxxxxxxxxxxxx>
Subject: [xen-unstable test] 25406: regressions - FAIL
Date: Thu, 13 Mar 2014 16:48:48 +0000

flight 25406 xen-unstable real [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/25406/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-freebsd10-amd64 10 guest-saverestore      fail REGR. vs. 25400
 test-amd64-i386-freebsd10-i386 10 guest-saverestore       fail REGR. vs. 25400
 test-amd64-i386-xend-qemut-winxpsp3  9 guest-saverestore  fail REGR. vs. 25400
 test-amd64-i386-xl-qemut-winxpsp3-vcpus1 9 guest-saverestore fail REGR. vs. 
25400
 test-amd64-i386-xend-winxpsp3  9 guest-saverestore        fail REGR. vs. 25400
 test-amd64-i386-xl-qemuu-winxpsp3-vcpus1 9 guest-saverestore fail REGR. vs. 
25400
 test-amd64-i386-xl-winxpsp3-vcpus1  9 guest-saverestore   fail REGR. vs. 25400
 test-amd64-amd64-xl-qemuu-win7-amd64  9 guest-saverestore fail REGR. vs. 25400
 test-amd64-amd64-xl-qemuu-winxpsp3  9 guest-saverestore   fail REGR. vs. 25400
 test-amd64-i386-xl-qemut-win7-amd64  9 guest-saverestore  fail REGR. vs. 25400
 test-amd64-i386-xl-win7-amd64  9 guest-saverestore        fail REGR. vs. 25400
 test-amd64-amd64-xl-qemut-winxpsp3  9 guest-saverestore   fail REGR. vs. 25400
 test-amd64-amd64-xl-winxpsp3  9 guest-saverestore         fail REGR. vs. 25400
 test-amd64-amd64-xl-qemut-win7-amd64  9 guest-saverestore fail REGR. vs. 25400
 test-amd64-i386-xl-qemuu-win7-amd64  9 guest-saverestore  fail REGR. vs. 25396
 test-amd64-amd64-xl-win7-amd64  9 guest-saverestore       fail REGR. vs. 25400

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl          10 migrate-support-check        fail   never pass
 test-amd64-amd64-xl-pcipt-intel  9 guest-start                 fail never pass

version targeted for testing:
 xen                  6e0f51c60487d74495aaba03728040050b6d885d
baseline version:
 xen                  dd2ef9d50d89c49e57d68318422b4ed2c2d426d5

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  Aravind Gopalakrishnan <Aravind.Gopalakrishnan@xxxxxxx>
  Chen Baozi <baozich@xxxxxxxxx>
  David Vrabel <david.vrabel@xxxxxxxxxx>
  Don Slutz <dslutz@xxxxxxxxxxx>
  George Dunlap <george.dunlap@xxxxxxxxxxxxx>
  Ian Campbell <ian.campbell@xxxxxxxxxx>
  Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
  Jan Beulich <jbeulich@xxxxxxxx>
  Joby Poriyath <joby.poriyath@xxxxxxxxxx>
  Julien Grall <julien.grall@xxxxxxxxxx>
  Keir Fraser <keir@xxxxxxx>
  Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
  Matthew Daley <mattd@xxxxxxxxxxx>
  Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
  Olaf Hering <olaf@xxxxxxxxx>
  Roger Pau Monnà <roger.pau@xxxxxxxxxx>
  Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
  Wei Liu <wei.liu2@xxxxxxxxxx>
------------------------------------------------------------

jobs:
 build-amd64-xend                                             pass    
 build-i386-xend                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-oldkern                                          pass    
 build-i386-oldkern                                           pass    
 build-amd64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-i386-rhel6hvm-amd                                 pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-i386-freebsd10-amd64                              fail    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-win7-amd64                               fail    
 test-amd64-i386-xl-win7-amd64                                fail    
 test-amd64-i386-xl-credit2                                   pass    
 test-amd64-i386-freebsd10-i386                               fail    
 test-amd64-amd64-xl-pcipt-intel                              fail    
 test-amd64-i386-rhel6hvm-intel                               pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-i386-xl-multivcpu                                 pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-xl-sedf-pin                                 pass    
 test-amd64-amd64-pv                                          pass    
 test-amd64-i386-pv                                           pass    
 test-amd64-amd64-xl-sedf                                     pass    
 test-amd64-i386-xl-qemut-winxpsp3-vcpus1                     fail    
 test-amd64-i386-xl-qemuu-winxpsp3-vcpus1                     fail    
 test-amd64-i386-xl-winxpsp3-vcpus1                           fail    
 test-amd64-i386-xend-qemut-winxpsp3                          fail    
 test-amd64-amd64-xl-qemut-winxpsp3                           fail    
 test-amd64-amd64-xl-qemuu-winxpsp3                           fail    
 test-amd64-i386-xend-winxpsp3                                fail    
 test-amd64-amd64-xl-winxpsp3                                 fail    


------------------------------------------------------------
sg-report-flight on osstest.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images

Logs, config files, etc. are available at
    http://www.chiark.greenend.org.uk/~xensrcts/logs

Test harness code can be found at
    http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 529 lines long.)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel