Re: [Xen-devel] [PATCH 5/5] xc_save: simplify switch_qemu_logdirty() by use stack strings

[Lai Jiangshan <laijs@xxxxxxxxxxxxxx>]

On 03/14/2014 12:54 AM, Ian Jackson wrote:
> Lai Jiangshan writes ("[PATCH 5/5] xc_save: simplify switch_qemu_logdirty() 
> by use stack strings"):
>> Signed-off-by: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>
> 
> Thanks for this submission.  This is quite fiddly to review.  Can you
> explain what the concrete benefit of this is ?
> 
Hi, Ian Jackson.

no concrete benefit, but help for reviewing:

simplify by "allocating" strings from stack.
reduce memory-allocation and reduce error-handling-branch.

path_cmd and path_ret strings are separated.

Thanks,
Lai


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel