[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v3 4/6] ioreq-server: on-demand creation of ioreq server
On Tue, 2014-03-11 at 10:54 +0000, Paul Durrant wrote: > > > -static void hvm_destroy_ioreq_page( > > > - struct domain *d, struct hvm_ioreq_page *iorp) > > > +static void hvm_destroy_ioreq_page(struct hvm_ioreq_server *s, bool_t > > buf) > > > { > > > - spin_lock(&iorp->lock); > > > + struct hvm_ioreq_page *iorp; > > > > > > - ASSERT(d->is_dying); > > > + iorp = buf ? &s->buf_ioreq : &s->ioreq; > > > > > > destroy_ring_for_helper(&iorp->va, iorp->page); > > > - > > > - spin_unlock(&iorp->lock); > > > > BTW, is there a reason you're getting rid of the locks here? > > > > Yes, I don't believe it is needed. This smells like a separate patch to me, but at the very least removing a lock needs mention in the commit message. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |