[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] libxl: Auto-assign NIC devids in initiate_domain_create

Ian Campbell writes ("Re: [PATCH] libxl: Auto-assign NIC devids in 
> On Thu, 2014-01-09 at 11:33 +0100, Stefan Bader wrote:
> > Date: Wed, 8 Jan 2014 18:26:59 +0100
> > Subject: [PATCH] libxl: Auto-assign NIC devids in initiate_domain_create
> > 
> > This will change initiate_domain_create to walk through NIC definitions
> > and automatically assign devids to those which have not assigned one.
> > The devids are needed later in domcreate_launch_dm (for HVM domains
> > using emulated NICs). The command string for starting the device-model
> > has those ids as part of its arguments.
> > Assignment of devids in the hotplug case is handled by libxl_device_nic_add
> > but that would be called too late in the startup case.
> > I also moved the call to libxl__device_nic_setdefault here as this seems
> > to be the only path leading there and avoids doing the loop a third time.
> > The two loops are trying to handle a case where the caller sets some devids
> > (not sure that should be valid) but leaves some unset.
> > 
> > Signed-off-by: Stefan Bader <stefan.bader@xxxxxxxxxxxxx>
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

I have backported this to 4.3.  It doesn't apply cleanly to 4.2; I
didn't investigate that further.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.