Re: [Xen-devel] [PATCH] xen: arm: increase priority of SGIs used as IPIs

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Thu, 13 Mar 2014, Oleksandr Tyshchenko wrote:
> Hello, all.
> 
> I tested this patch (with debug patch) when I was looking for solution
> to fix "simultaneous cross-interrupts" (see 1.1):
> http://lists.xenproject.org/archives/html/xen-devel/2014-01/msg02685.html
> This patch didn't fix my issue.
> When the solution was founded I forgot about this patch)
> 
> Now I am using next solution:
> http://marc.info/?l=xen-devel&m=139153089412362&w=2

Speaking of which, it should probably be applied to xen-unstable now
that the gate is open?

> But anyway, your patch works and looks good and I don't mind it.
> Thank you.
> 
> Oleksandr Tyshchenko | Embedded Developer
> GlobalLogic
> www.globallogic.com
> 
> On Thu, Mar 13, 2014 at 2:56 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> > On 03/13/2014 12:45 PM, Ian Campbell wrote:
> >> On Thu, 2014-03-13 at 12:33 +0000, Julien Grall wrote:
> >>> Hi Ian,
> >>>
> >>> On 01/28/2014 04:51 PM, Ian Campbell wrote:
> >>>>      /* Set PPI and SGI priorities */
> >>>> -    for (i = 0; i < 32; i += 4)
> >>>> -        GICD[GICD_IPRIORITYR + i / 4] = 0xa0a0a0a0;
> >>>> +    for (i = 0; i < 16; i += 4)
> >>>> +        GICD[GICD_IPRIORITYR + i / 4] =
> >>>> +            GIC_PRI_IPI<<24 | GIC_PRI_IPI<<16 | GIC_PRI_IPI<<8 | 
> >>>> GIC_PRI_IPI;
> >>>> +    for (i = 16; i < 32; i += 4)
> >>>> +        GICD[GICD_IPRIORITYR + i / 4] =
> >>>> +            GIC_PRI_IRQ<<24 | GIC_PRI_IRQ<<16 | GIC_PRI_IRQ<<8 | 
> >>>> GIC_PRI_IRQ;
> >>>
> >>> I'm wondering if it's necessary to set the priority for PPIs. It will be
> >>> overridden later when the interrupt will be setup. Until that time, the
> >>> interrupt is not enabled.
> >>
> >> Strictly speaking probably not, but there isn't much harm in setting a
> >> sane default I suppose.
> >
> > Right, I didn't see that we also do that for SPIs.
> >
> > I have a minor change to request, can you divide the comment "Set PPI
> > and SGI priorities" in 2 to reflect was does each loop?
> >
> > Except that:
> >
> > Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>
> >
> > Regards,
> >
> > --
> > Julien Grall
> 
> 
> 
> -- 
> 
> Name | Title
> GlobalLogic
> P +x.xxx.xxx.xxxx  M +x.xxx.xxx.xxxx  S skype
> www.globallogic.com
> 
> http://www.globallogic.com/email_disclaimer.txt
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel