Re: [Xen-devel] [PATCH v2 10/15] xen/xsm: flask: flask_copying_string is taking a XEN_GUEST_HANDLE as first param

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 17 Mar 2014, Jan Beulich wrote:
> >>> On 17.03.14 at 15:06, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> > Rather than x86, on ARM XEN_GUEST_HANDLE and XEN_GUEST_HANDLE_PARAM are
> > not compatible. This will result to a compilation failure on ARM when XSM
> > will be enabled.
> > 
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> > Acked-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > ---
> >  xen/xsm/flask/flask_op.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/xen/xsm/flask/flask_op.c b/xen/xsm/flask/flask_op.c
> > index 9dd9081..85a615b 100644
> > --- a/xen/xsm/flask/flask_op.c
> > +++ b/xen/xsm/flask/flask_op.c
> > @@ -76,7 +76,7 @@ static int domain_has_security(struct domain *d, u32 
> > perms)
> >                          perms, NULL);
> >  }
> >  
> > -static int flask_copyin_string(XEN_GUEST_HANDLE_PARAM(char) u_buf, char 
> > **buf,
> > +static int flask_copyin_string(XEN_GUEST_HANDLE(char) u_buf, char **buf,
> 
> Wasn't the original intention for them to be converted when passed
> to functions, rather than getting passed verbatim?
 
The change is correct: flask_copyin_string is always called passing
struct field pointers as first argument. It is never called passing
hypercall arguments directly.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel