Re: [Xen-devel] [PATCH v2] libxc: Fix buffer length for get_suspend_file

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 03/18/2014 01:58 PM, Ian Jackson wrote:
> Declaring a formal parameter to have an array type doesn't result in
> the parameter actually having an array type.  The type is "adjusted"
> to a pointer.  (C99 6.9.1(7), 6.7.5.3.)
> 
> So the use of sizeof in xc_suspend.c:get_suspend_file was wrong.
> Instead, use the #define.  Also get rid of the array size, as it is
> misleading.
> 
> Newer versions of gcc warn about the erroneous code:
>   xc_suspend.c:39:25: error: argument to 'sizeof' in 'snprintf' call
>     is the same expression as the destination; did you mean to provide
>     an explicit length? [-Werror=sizeof-pointer-memaccess]
> 
> Reported-By: Julien Grall <julien.grall@xxxxxxxxxx>
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
> CC: Julien Grall <julien.grall@xxxxxxxxxx>

Great, I'm able to compile libxc with gcc 4.8:

Tested-by: Julien Grall <julien.grall@xxxxxxxxxx>

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel