Re: [Xen-devel] [PATCH-4.5 v3 10/12] xen/arm: don't protect GICH and lr_queue accesses with gic.lock

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 26 Feb 2014, Julien Grall wrote:
> Hi Stefano,
> 
> On 26/02/14 18:39, Stefano Stabellini wrote:
> > GICH is banked, protect accesses by disabling interrupts.
> > Protect lr_queue accesses with the vgic.lock only.
> 
> When the interrupt is an SPI, the lr_queue is shared between every VCPU. Using
> only vgic.lock seems wrong to me.

Even though lr_queue is a field in a struct that can be per domain for
irq > 32, the lr_pending queue is always per vcpu, in fact it keeps
track of the irqs waiting to go into lr registers, that are banked.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel